This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Improve ARM architecture detection: arm64 and armv7 #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdcastro
commented
Oct 14, 2020
| if (unameOut.includes('armv7')) return 'armv7'; | ||
| return ''; | ||
| } | ||
|
|
There was a problem hiding this comment.
It was only after writing and testing the code that I realised that there is already an open PR on the same topic: #101
I'd say that this PR (#106) is a bit more robust / conservative and complete, because:
- It falls back to the existing
/proc/cpuinfoimplementation ifunameis not available (however unlikely). Note thatspawnSync('uname', ['-a'])does not throw an Error ifunamedoes not exist, but setsuname.errorwhich the code detects. uname -ais a bit more robust thanuname -m(thinking of all different Unix kernels out there: BSD, Solaris, Linux, even perhaps macOS...), as it does not rely on a particular field or implementation ofuname.- The detection is case insensitive.
- It detects
arm64(e.g. Raspberry Pi 4) in addition toarmv7(e.g. Raspberry Pi 2/3). I've tested on both!
There was a problem hiding this comment.
Oh ok sorry I misunderstood the comment
There was a problem hiding this comment.
@pdcastro I really appreciate your help here and the descriptive comment!
|
I don’t think they will answer
|
|
@leerob please consider merging this |
leerob
approved these changes
Mar 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
pkgin a Docker Desktop ARM-image container on an Intel laptop, usingbinfmt_misc/ QEMU architecture emulation,/proc/cpuinforeports the Intel processor rather than the emulated ARM processor. The existing architecture detection then fails. Also, the existing detection code does not support arm64 (e.g. the Raspberry Pi 4), reportingarmv6instead.